Fixes #6276 - Support non-standard domains in SNI and X509. #6296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backported support for IP addresses in X509 (from #5379). Introduced SslContextFactory.Client.SniProvider to allow applications to specify the SNI names to send to the server. Improved logging of SNI processing. Signed-off-by: Simone Bordet <[email protected]>
Fixed test failures on CI due to lack of IPv6 support. Signed-off-by: Simone Bordet <[email protected]>
Fixed the non-domain SNI provider to send the server host, not the local host (doh!). Skip X509 matching over IP addresses when the host does not look like an IP address, to avoid reverse DNS lookup. Signed-off-by: Simone Bordet <[email protected]>
Fixed checkstyle issue. Signed-off-by: Simone Bordet <[email protected]>
gregw
approved these changes
May 20, 2021
sbordet
added a commit
that referenced
this pull request
May 21, 2021
Improved support for IP addresses in X509 (after #5379). Introduced SslContextFactory.Client.SniProvider to allow applications to specify the SNI names to send to the server. Improved logging of SNI processing. Skip X509 matching over IP addresses when the host does not look like an IP address, to avoid reverse DNS lookup. Signed-off-by: Simone Bordet <[email protected]> (cherry picked from commit 04df6d4)
sbordet
added a commit
that referenced
this pull request
May 24, 2021
…6311) * Fixes #6276 - Support non-standard domains in SNI and X509. (#6296) Improved support for IP addresses in X509 (after #5379). Introduced SslContextFactory.Client.SniProvider to allow applications to specify the SNI names to send to the server. Improved logging of SNI processing. Skip X509 matching over IP addresses when the host does not look like an IP address, to avoid reverse DNS lookup. Signed-off-by: Simone Bordet <[email protected]> (cherry picked from commit 04df6d4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported support for IP addresses in X509 (from #5379).
Introduced SslContextFactory.Client.SniProvider to allow applications to specify the SNI names to send to the server.
Improved logging of SNI processing.
Signed-off-by: Simone Bordet [email protected]