Skip to content

Issue #5081 - HouseKeeper synchronization #5099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 5, 2020
Merged

Issue #5081 - HouseKeeper synchronization #5099

merged 4 commits into from
Aug 5, 2020

Conversation

janbartel
Copy link
Contributor

Closes #5081

Make setIntervalSec synchronized, refactor findScheduler to being inside startScavenge.

janbartel added 2 commits July 29, 2020 12:34
@janbartel
Issue #5081 HouseKeeper synchronization
1f4a280 
Signed-off-by: Jan Bartel <[email protected]>
@janbartel
Issue #5081 Tidy up
6849c54 
Signed-off-by: Jan Bartel <[email protected]>
@janbartel janbartel self-assigned this Jul 29, 2020
@janbartel janbartel linked an issue Jul 29, 2020 that may be closed by this pull request
Review HouseKeeper locking #5081
Closed
@janbartel janbartel requested a review from sbordet July 29, 2020 11:47
sbordet
sbordet requested changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Runner finally block accesses fields that are synchronized elsewhere.
  • getIntervalSec() should sync.
  • In stopScavenging(), _runner = null should be inside the sync block.
  • toString() should be synchronized.

@joakime joakime changed the title Jetty 9.4.x 5081 housekeeper synchronization Issue #5081 - HouseKeeper synchronization Jul 30, 2020
@janbartel janbartel requested a review from sbordet August 3, 2020 08:06
@janbartel
Issue #5081 Fix test
6df5074 
Signed-off-by: Jan Bartel <[email protected]>
@sbordet
Copy link
Contributor

sbordet commented Aug 5, 2020

@janbartel remember to convert to AutoLock when merging to 10.

@janbartel janbartel merged commit 4f57810 into jetty-9.4.x Aug 5, 2020
@janbartel janbartel deleted the jetty-9.4.x-5081-housekeeper-synchronization branch August 5, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbordet sbordet sbordet approved these changes

Assignees

@janbartel janbartel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review HouseKeeper locking
2 participants
@janbartel @sbordet