-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetty 9.4.x 4331 async close complete #4378
Conversation
Added test harness to reproduce unready completing write. Fixed test by not closing output prior to becoming READY Signed-off-by: Greg Wilkins <[email protected]>
Test harness to reproduce unready when closing/completing. Signed-off-by: Greg Wilkins <[email protected]>
test both PENDING and UNREADY Signed-off-by: Greg Wilkins <[email protected]>
test cleanups Signed-off-by: Greg Wilkins <[email protected]>
ERROR state still needs to be closed! Signed-off-by: Greg Wilkins <[email protected]>
…-4331-asyncCloseComplete
close after last blocking write Signed-off-by: Greg Wilkins <[email protected]>
If completion has to do a flush, then we need a call to closed to avoid leaking buffers. Signed-off-by: Greg Wilkins <[email protected]>
…-4331-asyncCloseComplete
WIP - moved the outstate from HttpOutput to HttpChannelState Error handling needs a big review Signed-off-by: Greg Wilkins <[email protected]>
@sbordet, @lachlan-roberts. I would not mind a little bit of review as I work through this PR... to make sure I don't commit too much effort in a wrong direction.
|
Reformat Signed-off-by: Greg Wilkins <[email protected]>
…-4331-asyncCloseComplete Signed-off-by: Greg Wilkins <[email protected]>
Closing this as a dead end. After review with @sbordet it was felt that moving HttpOutput.State into HttpChannelState was a wrong direction an that the HttpOutput should know it's own API state. However there were some good cleanups, so we need to extract some ideas into a new branch and PR. |
Fix for #4331 Implement async close and/or complete when PENDING or UNREADY.
This includes PR #4377