avoid non necessary objects allocation if session do not have any attributes data #4375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ributes data Signed-off-by: olivier lamy <[email protected]>
Signed-off-by: olivier lamy <[email protected]>
Signed-off-by: olivier lamy <[email protected]>
janbartel
approved these changes
Nov 28, 2019
| "select * from " + TABLE + | ||
| " where " + ID_COL + " = ? and " + CONTEXT_COL + | ||
| " = ? and virtualHost = ?" ); | ||
| statement.setString(1, data.getId() ); |
There was a problem hiding this comment.
how are you getting away with the extra space before the final ); ??? Is checkstyle broken?
There was a problem hiding this comment.
ohh my bad I usually avoid only blank line. But agree I have to take care of spaces as well
| } | ||
| } | ||
| else | ||
| { | ||
| statement.setBinaryStream( 7, EMPTY, 0); |
There was a problem hiding this comment.
Does this deserialize correctly? Serializing an empty map would be a different result than an empty byte string.
There was a problem hiding this comment.
just an empty map but good point I will add a test for that.
Signed-off-by: olivier lamy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: olivier lamy [email protected]