Issue #2796 - Max local stream count exceeded when request fails. #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewed other possible places where max local stream count may overflow. Fixed handling of HTTP/2 stream idle timeouts. Signed-off-by: Simone Bordet <[email protected]>
gregw
reviewed
Oct 10, 2018
Bound release of the channel to stream close event. Signed-off-by: Simone Bordet <[email protected]>
|
@gregw I have updated the code as discussed, and ran a bunch of load tests, seems good to me. |
gregw
approved these changes
Oct 15, 2018
jetty-http2/http2-common/src/main/java/org/eclipse/jetty/http2/HTTP2Session.java
Show resolved
Hide resolved
| @@ -87,23 +92,31 @@ protected HttpChannelOverHTTP2 newHttpChannel() | |||
|
|
|||
| protected void release(HttpChannelOverHTTP2 channel) | |||
| { | |||
| if (LOG.isDebugEnabled()) | |||
| LOG.debug("Released {}", channel); | |||
| // Only non-push channels are released. | |||
There was a problem hiding this comment.
this comment is now wrong.
s/released/recycled/
Updates after review. Signed-off-by: Simone Bordet <[email protected]>
Restored smaller maxContentLength to avoid that the test takes too much time and fails. Signed-off-by: Simone Bordet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2796.
Reviewed other possible places where max local stream count may
overflow.
Fixed handling of HTTP/2 stream idle timeouts.
Signed-off-by: Simone Bordet [email protected]