Fixes #11413 - Conscrypt does not support server-side SNI. #12549
+53
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified `SecureRequestCustomizer` to use `ExtendedSSLSession` APIs instead of relying on SSLSession attributes, that do not work in Conscrypt. Signed-off-by: Simone Bordet <[email protected]>
lorban
requested changes
Nov 19, 2024
...t-server/src/test/java/org/eclipse/jetty/alpn/conscrypt/server/ConscryptHTTP2ServerTest.java
Show resolved
Hide resolved
lorban
previously approved these changes
Nov 20, 2024
gregw
requested changes
Nov 20, 2024
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/SecureRequestCustomizer.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/ssl/SniX509ExtendedKeyManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Simone Bordet <[email protected]>
gregw
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified
SecureRequestCustomizerto useExtendedSSLSessionAPIs instead of relying on SSLSession attributes, that do not work in Conscrypt.