Fixes #9121 - Flaky BlockedWritesWithSmallThreadPoolTest.testServerThreadsBlockedInWrites(). #12178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…readsBlockedInWrites(). The test uncovered a larger problem detailed in the issue: the Handler Callback should be non-blocking. Since all implementations of HttpStream are non-blocking, overridden HttpStream.getInvocationType() to return NON_BLOCKING. This guarantees that even in case of all server threads blocked, blocked/pending writes can be completed. Signed-off-by: Simone Bordet <[email protected]>
gregw
approved these changes
Aug 20, 2024
gregw
requested changes
Aug 20, 2024
| // Write a large content to cause TCP congestion. | ||
| response.write(true, ByteBuffer.wrap(new byte[contentLength]), callback); | ||
| // Blocking write a large content to cause TCP congestion. | ||
| Content.Sink.write(response, true, ByteBuffer.wrap(new byte[contentLength])); |
There was a problem hiding this comment.
Can we test both async and blocking writes here?
Signed-off-by: Simone Bordet <[email protected]>
gregw
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test uncovered a larger problem detailed in the issue: the Handler Callback should be non-blocking.
Since all implementations of HttpStream are non-blocking, overridden HttpStream.getInvocationType() to return NON_BLOCKING.
This guarantees that even in case of all server threads blocked, blocked/pending writes can be completed.