Fix Regression on ee9 / ee8 MultiPart parsing #12031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joakime
added
Bug
gregw
requested changes
Jul 12, 2024
...e9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/MultiPartFormInputStream.java
Outdated
Show resolved
Hide resolved
joakime
changed the title
+ More multipart parsing errors return 400, not 500 now.
|
I've added more tests for this regression, and fixed many of the 500 vs 400 status returns in the process. (more are returning 400 now) |
gregw
requested changes
Jul 15, 2024
...e9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/MultiPartFormInputStream.java
Outdated
Show resolved
Hide resolved
* Request.getParts() catches IOExceptions from multiParts.getParts() and wraps them in a BadMessageException to ensure that a 400 Bad Request response shows up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Jetty 10 / Jetty 11 when a
multipart/form-datais sent with an empty request body, it would result in an error status 400 (Bad Request).The implementation in ee9 / ee8 in Jetty 12 returns an error status 500.
Introduce test cases and fix to restore this behavior.