Fix NPE when GzipHandler is writing and an exception is thrown by the wrapping's Response.write() #12025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by the wrapping's Response.write() Signed-off-by: Ludovic Orban <[email protected]>
sbordet
requested changes
Jul 10, 2024
...etty-server/src/main/java/org/eclipse/jetty/server/handler/gzip/GzipResponseAndCallback.java
Show resolved
Hide resolved
...etty-server/src/main/java/org/eclipse/jetty/server/handler/gzip/GzipResponseAndCallback.java
Outdated
Show resolved
Hide resolved
...y-core/jetty-server/src/test/java/org/eclipse/jetty/server/handler/gzip/GzipHandlerTest.java
Outdated
Show resolved
Hide resolved
gregw
previously requested changes
Jul 10, 2024
...etty-server/src/main/java/org/eclipse/jetty/server/handler/gzip/GzipResponseAndCallback.java
Show resolved
Hide resolved
…0.x/12022-npe-in-GzipHandler-write-failure
Signed-off-by: Ludovic Orban <[email protected]>
|
@lorban something looks broken in this now. |
sbordet
previously approved these changes
Jul 12, 2024
Signed-off-by: Ludovic Orban <[email protected]>
|
I've reverted most of the suggested cleanups because they break the logic in subtle ways: |
sbordet
approved these changes
Jul 16, 2024
lorban
deleted the
fix/jetty-12.0.x/12022-npe-in-GzipHandler-write-failure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GzipBufferCBdoes not set theGZStatetoFINISHEDwhen it fails, which leaves the code trying to finish up gzipping while everything has already been cleaned up.Fixes #12022