Deny HTTP/3 connection creation for clients missing cert when needClientAuth is true #12014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ludovic Orban <[email protected]>
lorban
changed the title
lorban
changed the title
…needed-client-cert
Signed-off-by: Ludovic Orban <[email protected]>
sbordet
requested changes
Jul 8, 2024
.../jetty-http3-tests/src/test/java/org/eclipse/jetty/http3/tests/AbstractClientServerTest.java
Outdated
Show resolved
Hide resolved
...ty-http3/jetty-http3-tests/src/test/java/org/eclipse/jetty/http3/tests/ClientServerTest.java
Outdated
Show resolved
Hide resolved
...ty-http3/jetty-http3-tests/src/test/java/org/eclipse/jetty/http3/tests/ClientServerTest.java
Outdated
Show resolved
Hide resolved
...quic/jetty-quic-server/src/main/java/org/eclipse/jetty/quic/server/ServerQuicConnection.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ludovic Orban <[email protected]>
Signed-off-by: Ludovic Orban <[email protected]>
Signed-off-by: Ludovic Orban <[email protected]>
Signed-off-by: Ludovic Orban <[email protected]>
…needed-client-cert
Signed-off-by: Ludovic Orban <[email protected]>
|
@sbordet I had to completely change the implementation as it was totally broken: the peer certificate is accessible only after Quiche declares the connection as established. |
sbordet
requested changes
Jul 10, 2024
...ty-quic/jetty-quic-server/src/main/java/org/eclipse/jetty/quic/server/ServerQuicSession.java
Outdated
Show resolved
Hide resolved
...ty-quic/jetty-quic-server/src/main/java/org/eclipse/jetty/quic/server/ServerQuicSession.java
Outdated
Show resolved
Hide resolved
...ty-quic/jetty-quic-server/src/main/java/org/eclipse/jetty/quic/server/ServerQuicSession.java
Outdated
Show resolved
Hide resolved
…needed-client-cert
Signed-off-by: Ludovic Orban <[email protected]>
sbordet
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no way to tell Quiche to refuse connections from clients who do not hold a client certificate, so when
SslContextFactory.needClientAuthis set to true and a HTTP/3 request is made, an explicit check for that config setting must be added to explicitly tell Quiche to close the connection when the client cert is missing.Fixes #11996