Fix openid.mod files for Jetty 12

[lachlan-roberts]

• we don't need ee8-10 variants of jetty-openid-baseloginservice.xml, jetty-openid.xml, or the ini template, just the core one is enough.
• the ee10-openid.mod is pointless because it doesn't do anything other than depend on openid.mod so it has been removed.
• ee8-openid.mod needed to specify its environment as ee8, was currently not working.

[sbordet]

Please check ModulesTest.testOpenidModules(), which has not been updated and passes but it should not.

[lachlan-roberts]

Please check ModulesTest.testOpenidModules(), which has not been updated and passes but it should not.

@sbordet it makes sense why this test is passing, it is using "ee8-openid", "ee9-openid", "openid", which all still exist (only ee10-openid was removed).

[sbordet]

@lachlan-roberts the test is passing, but it's just spitting out errors, so it should not pass.
Please run it, and verify why it passes despite the errors.

[joakime]

You have 2 options:

1. Use the modules/openid/ directory properly.
2. Don't copy the live jetty-home xml to the jetty-base xml.

[joakime]

ugh, don't copy a live XML from jetty-home to jetty-base.
The modules/openid/ directory exists for a reason.

[lachlan-roberts]

I thought it was useful, because if the xml was deleted from jetty-base/etc then it still works.
And the use of this XML is optional, but it would be annoying to have to manually copy it over when you need to use it.

Anyway I reverted this change so the file is back at modules/openid/jetty-openid-baseloginservice.xml.

[lachlan-roberts]

@lachlan-roberts the test is passing, but it's just spitting out errors, so it should not pass.
Please run it, and verify why it passes despite the errors.

I checked the output of the test. The test is not setting up OpenID correctly, it just adding the module and verifying that it has the message Issuer was not configured in the logs, which comes from that big stacktrace.

We have tests like org.eclipse.jetty.ee10.tests.distribution.OpenIdTests and org.eclipse.jetty.ee9.tests.distribution.OpenIdTests which test OpenID with proper configuration and a webapp which uses it.

addressed review