Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #11893 fix maven helloworld example #11896

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

janbartel
Copy link
Contributor

Closes #11893

Update helloworld maven example

@janbartel janbartel self-assigned this Jun 10, 2024
@olamy
Copy link
Member

olamy commented Jun 10, 2024

Sadly, we do not have an automatic way to validate those code fragments via compilation :( (grabbing code fragment from a source file located in github and building via the project)

I cannot find any extension here https://github.com/asciidoctor/asciidoctor.org/blob/main/docs/extensions.adoc
Maybe writing an extension for this?

hehe, please note it's possible with Old Good Maven :P https://maven.apache.org/doxia/macros/index.html#snippet-macro

@janbartel janbartel merged commit 45562b0 into jetty-12.0.x Jun 10, 2024
11 checks passed
@janbartel janbartel deleted the jetty-12.0.x-11893-fix-maven-helloworld branch June 10, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Hello World Example Fails to Run
3 participants