-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce Cross Context Dispatch in Jetty 12 #11451
Conversation
This PR is on track for 12.0.8 release, right? |
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
@joakime @lachlan-roberts @olamy This is a big PR that we want in this release cycled (which may be rushed). Can you start reviewing this ASAP so it makes it in. The key areas to consider are:
@joakime any thoughts on better testing all of this? |
PR #11516 is needed for the testing additions I'm working on. |
this is passing TCK. Need some Arquillian changes though. arquillian/arquillian-container-jetty#186 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge this, it is quite good as it currently stands.
We'll keep adding testing it and refining over time.
…cross-context-dispatch
@@ -339,6 +339,7 @@ protected void service(HttpServletRequest request, HttpServletResponse resp) | |||
assertThat(connection.getResponse(), containsString(" 200 OK")); | |||
} | |||
|
|||
cookieHistory.forEach(System.err::println); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should remove this System.err.println
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets get this merged. It's a good change.
Implement cross context dispatch.