Add suppressed failures in Callback failed #11435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an exception is thrown during failure handling, then record the original failure as a suppressed Throwable on the thrown exception
lorban
reviewed
Feb 22, 2024
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/Callback.java
Show resolved
Hide resolved
lorban
previously approved these changes
Feb 22, 2024
lorban
previously approved these changes
Feb 28, 2024
sbordet
requested changes
Feb 28, 2024
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/Callback.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/Callback.java
Outdated
Show resolved
Hide resolved
|
I worry that all of these suppressed exceptions might reveal internals that we don't want to. |
sbordet
requested changes
Feb 29, 2024
| } | ||
| finally | ||
| catch (Throwable t) |
There was a problem hiding this comment.
Please use same style as line 295.
| cb2.failed(x); | ||
| } | ||
|
|
||
| Callback.failed(cb2, x); |
There was a problem hiding this comment.
Put this back inside a finally.
| @@ -533,7 +572,7 @@ public void succeeded() | |||
| @Override | |||
| public void failed(Throwable x) | |||
| { | |||
| callback.failed(x); | |||
| Callback.failed(callback, x); | |||
| super.failed(x); | |||
There was a problem hiding this comment.
Change this to have super.failed() inside a finally, so it gets called in all cases.
sbordet
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better recording of issues like #11431
If an exception is thrown during failure handling, then record the original failure as a suppressed
Throwableon the thrown exception