Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #11401 StringBuilder rather than StringBuffer #11406

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Fix #11401 StringBuilder rather than StringBuffer #11406

merged 1 commit into from
Feb 19, 2024

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Feb 14, 2024

Fix #11401 StringBuilder rather than StringBuffer

Surprising we missed this one for so long.

However, as it is a slight API change, we might have to delay until 12.1.0 ?

@gregw gregw requested review from joakime and janbartel February 14, 2024 11:46
janbartel
janbartel approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@janbartel janbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're all protected methods, not public, so I think we could get away with the api change? If you're really worried, you could keep the old method signature, deprecate it, and convert to the new method signature?

@gregw gregw merged commit 08174a3 into jetty-12.0.x Feb 19, 2024
8 checks passed
@gregw gregw deleted the fix/jetty-12/11401/StringBuilder branch February 19, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janbartel janbartel janbartel approved these changes

@joakime joakime Awaiting requested review from joakime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace StringBuffer with StringBuilder
2 participants
@gregw @janbartel