Issue #10956 - Send Reset NO_ERROR for HTTP/2 #11029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed duplicate handling from servlet. Now only handled in core on first demand. Added additional tests.
added the willRead method to HttpStream and Request to allow signal that a read will be attempted.
joakime
changed the title
…/110956/Reset_NO_ERROR
lorban
requested changes
Dec 11, 2023
| if (expects100Continue) | ||
| { | ||
| expects100Continue = false; | ||
| send(requestMetaData, HttpGenerator.CONTINUE_100_INFO, false, null, Callback.NOOP); |
There was a problem hiding this comment.
Now this makes me wonder if this isn't racing with a user-generated write? I mean such handler:
boolean handle(Request req, Response resp, Callback callback)
{
req.demand(() -> {}); // this triggers a write with a NOOP callback
resp.write(true, BufferUtil.EMPTY, callback); // doesn't this risk a WritePendingException?
}
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/Request.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/HttpStream.java
Outdated
Show resolved
Hide resolved
...ports/src/test/java/org/eclipse/jetty/ee10/test/client/transport/HttpClientContinueTest.java
Outdated
Show resolved
Hide resolved
...ports/src/test/java/org/eclipse/jetty/ee10/test/client/transport/HttpClientContinueTest.java
Show resolved
Hide resolved
...ports/src/test/java/org/eclipse/jetty/ee10/test/client/transport/HttpClientContinueTest.java
Outdated
Show resolved
Hide resolved
|
@sbordet @lorban can you just review the parts of this that are extra to #10957 @sbordet I've made changes to the h2 server side to do the reset(NO_ERROR), but I've not yet changed the client side to handle it. Not exactly sure what we should do there (if anything). Need to chat. @lorban can you look at duplicating the h2 changes in h3 once we agree they are correct. |
Moved all 100 continues handling into HttpChannelState and protected it from concurrent writes
…/110956/Reset_NO_ERROR # Conflicts: # jetty-core/jetty-http2/jetty-http2-server/src/main/java/org/eclipse/jetty/http2/server/internal/HttpStreamOverHTTP2.java
|
there is a better way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10956