-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve and test jetty.sh
behaviors
#10753
Conversation
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
…t, or process will switch to JETTY_USER Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
@gregw this is the new PR with jetty.sh changes, including testing various configurations on docker instances. |
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
jetty.sh
behaviorsjetty.sh
behaviors
@@ -427,16 +472,17 @@ then | |||
do | |||
if [ -r "$XMLFILE" ] && [ -f "$XMLFILE" ] | |||
then | |||
JETTY_ARGS=(${JETTY_ARGS[*]} "$XMLFILE") | |||
JETTY_ARGS[${#JETTY_ARGS[@]}]=$XMLFILE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still need the double quotes
JETTY_ARGS[${#JETTY_ARGS[@]}]=$XMLFILE | |
JETTY_ARGS[${#JETTY_ARGS[@]}]="$XMLFILE" |
I did the following test:
[] TEST=("foo" "bar")
[] echo ${FOO[*]}
foo bar bob
[] TEST=("foo" "bar")
[] echo ${TEST[*]}
foo bar
[] TEST[2]=bob
[] echo ${TEST[*]}
foo bar bob
[] TEST[3]=with space
bash: `TEST[3]': not a valid identifier
Command 'space' not found, but can be installed with:
sudo snap install space
[] TEST[3]="with space"
[] echo ${TEST[*]}
foo bar bob with space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh!!!! It works because it is a single variable:
[] WITH_SPACES='var with spaces'
[] TEST[4]=$WITH_SPACES
This is sooooo subtle! bash is getting more perl like!
This is a branch of PR #10700
It adds Docker testing, which may or may not be a good idea (performance wise / time wise)