Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and test jetty.sh behaviors #10753

Merged
merged 20 commits into from
Oct 25, 2023

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Oct 18, 2023

This is a branch of PR #10700

It adds Docker testing, which may or may not be a good idea (performance wise / time wise)

@joakime joakime self-assigned this Oct 18, 2023
@joakime joakime added the Bug For general bugs on Jetty side label Oct 18, 2023
@joakime joakime added this to the 10.0.x milestone Oct 18, 2023
@joakime joakime marked this pull request as ready for review October 19, 2023 19:24
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
@joakime
Copy link
Contributor Author

joakime commented Oct 20, 2023

@gregw this is the new PR with jetty.sh changes, including testing various configurations on docker instances.

Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
@joakime joakime requested a review from gregw October 24, 2023 21:56
@gregw gregw changed the title Experimenting with Docker images to test jetty.sh behaviors Improve and test jetty.sh behaviors Oct 24, 2023
@@ -427,16 +472,17 @@ then
do
if [ -r "$XMLFILE" ] && [ -f "$XMLFILE" ]
then
JETTY_ARGS=(${JETTY_ARGS[*]} "$XMLFILE")
JETTY_ARGS[${#JETTY_ARGS[@]}]=$XMLFILE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need the double quotes

Suggested change
JETTY_ARGS[${#JETTY_ARGS[@]}]=$XMLFILE
JETTY_ARGS[${#JETTY_ARGS[@]}]="$XMLFILE"

I did the following test:

[] TEST=("foo" "bar")

[] echo ${FOO[*]}
foo bar bob

[] TEST=("foo" "bar")

[] echo ${TEST[*]}
foo bar

[] TEST[2]=bob

[] echo ${TEST[*]}
foo bar bob

[] TEST[3]=with space
bash: `TEST[3]': not a valid identifier
Command 'space' not found, but can be installed with:
sudo snap install space

[] TEST[3]="with space"

[] echo ${TEST[*]}
foo bar bob with space

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh!!!! It works because it is a single variable:

[] WITH_SPACES='var with spaces'

[] TEST[4]=$WITH_SPACES

This is sooooo subtle! bash is getting more perl like!

@joakime joakime merged commit 92f62a1 into jetty-10.0.x Oct 25, 2023
4 checks passed
@joakime joakime deleted the fix/10.0.x/jetty-sh-docker-testing branch October 25, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants