Issue #10688 add Jetty 12.0.x ee8 osgi

[olamy]

issue #10688

[claesrosell]

I am playing with this now and I found this problem so far:
The Bundle-Activator header seems to be wrong in the generated MANIFEST.MF of the bundle "org.eclipse.jetty.ee8.osgi.boot".

The class of the Activator is wrongly named "EE9Activator" and the generated header is: org.eclipse.jetty.ee8.osgi.boot.ee8Activator with lowercase EE.

[claesrosell]

BTW, I didn't intend to do a complete review, I just happened to press the wrong button when I intended to add some ee8/ee9 comments. Sorry.

[olamy]

BTW, I didn't intend to do a complete review, I just happened to press the wrong button when I intended to add some ee8/ee9 comments. Sorry.

no worries. we are happy to get feedback from real users :)
ah you found a problem in the tool we use for translating sources from ee9 to ee8.
I need to fix the generated class name.

[olamy]

back to draft as I found some issues

[claesrosell]

back to draft as I found some issues

Should I await modify-sources-plugin 1.0.8 before testing this?

[olamy]

back to draft as I found some issues

Should I await modify-sources-plugin 1.0.8 before testing this?

yes sorry for that. But this has trigger some more issues :(

[olamy]

@claesrosell problem fixed. feel free to test again. Thanks for reporting the issue!

[merks]

Sorry, but I don't have the knowledge or skills to actually review the changes.

Only @claesrosell can really confirm if the generated results are correct and functional when used by BIRT...

[claesrosell]

Sorry, but I don't have the knowledge or skills to actually review the changes.

Only @claesrosell can really confirm if the generated results are correct and functional when used by BIRT...

I will try to test the latest changes and see if I can get the BIRT WebViewer to work.

[olamy]

@merks @claesrosell thanks for your help!
No rush next release will be in 3 weeks ish

[janbartel]

@olamy I don't see any ee8.osgi tests on the CI build for this PR?

[olamy]

@olamy I don't see any ee8.osgi tests on the CI build for this PR?

@janbartel
yup forgot that. This obviously needs more fix...

the sources doesn't manage such code res.add(mavenBundle().groupId("org.eclipse.jetty.toolchain").artifactId("jetty-javax-servlet-api").versionAsInProject().start());

I need to figure out something different.

[olamy]

@merks @claesrosell we plan to merge this soon have a release probably next week

[claesrosell]

I will work on getting the Birt webviewer working today. The problem as it looks now is that the Birt Webviewer creates a WebAppContext and register it as an OSGI service and that scenario does not seem to be supported by Jetty anymore. So I will probably need to create a web-bundle instead.