Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty 12.0.x 10582 servlethttpwrapper #10587

Merged
merged 6 commits into from
Oct 12, 2023

Conversation

janbartel
Copy link
Contributor

Closes #10582

Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now need a specific test to check that we can handle non HTTP Servlet wrappers for request and response.

P.S. we can probably squeak this into 12.0.2 if it is ready soon

@janbartel janbartel requested a review from gregw October 3, 2023 04:13
Comment on lines 138 to 140
HttpServletRequest wrappedRequest = new ServletRequestHttpWrapper(request);
HttpServletResponse wrappedResponse = new ServletResponseHttpWrapper(response);
chain.doFilter(wrappedRequest, wrappedResponse);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to see:

Suggested change
HttpServletRequest wrappedRequest = new ServletRequestHttpWrapper(request);
HttpServletResponse wrappedResponse = new ServletResponseHttpWrapper(response);
chain.doFilter(wrappedRequest, wrappedResponse);
chain.doFilter(new ServletRequestWrapper(request), new ServletResponseWrapper(response));

@janbartel janbartel requested a review from gregw October 3, 2023 05:33
@janbartel janbartel merged commit fffbab0 into jetty-12.0.x Oct 12, 2023
2 checks passed
@janbartel janbartel deleted the jetty-12.0.x-10582-servlethttpwrapper branch October 12, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

NPE when including a directory that should be resolved with servlet-mapped welcome file
2 participants