-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetty 12.0.x 10582 servlethttpwrapper #10587
Jetty 12.0.x 10582 servlethttpwrapper #10587
Conversation
…10582-servlethttpwrapper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now need a specific test to check that we can handle non HTTP Servlet wrappers for request and response.
P.S. we can probably squeak this into 12.0.2 if it is ready soon
HttpServletRequest wrappedRequest = new ServletRequestHttpWrapper(request); | ||
HttpServletResponse wrappedResponse = new ServletResponseHttpWrapper(response); | ||
chain.doFilter(wrappedRequest, wrappedResponse); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to see:
HttpServletRequest wrappedRequest = new ServletRequestHttpWrapper(request); | |
HttpServletResponse wrappedResponse = new ServletResponseHttpWrapper(response); | |
chain.doFilter(wrappedRequest, wrappedResponse); | |
chain.doFilter(new ServletRequestWrapper(request), new ServletResponseWrapper(response)); |
…10582-servlethttpwrapper
Closes #10582