Fix #9169 refine idle timeout and failure #10418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only fail request callback if a failure has not been otherwise notified. Slight optimization for failing idle timeouts by avoiding double lock.
Only fail request callback if a failure has not been otherwise notified. Slight optimization for failing idle timeouts by avoiding double lock.
lachlan-roberts
approved these changes
Aug 28, 2023
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal/HttpChannelState.java
Outdated
Show resolved
Hide resolved
joakime
reviewed
Aug 28, 2023
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal/HttpChannelState.java
Show resolved
Hide resolved
Only fail request callback if a failure has not been otherwise notified. Slight optimization for failing idle timeouts by avoiding double lock. Always create a failure if failing the callback.
Only fail request callback if a failure has not been otherwise notified. Slight optimization for failing idle timeouts by avoiding double lock. Always create a failure if failing the callback.
joakime
approved these changes
Aug 29, 2023
|
@sbordet please have a look at this first thing, as I think it is a contender to slip into 12.0.1 |
sbordet
approved these changes
Aug 29, 2023
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal/HttpChannelState.java
Outdated
Show resolved
Hide resolved
Only fail request callback if a failure has not been otherwise notified. Slight optimization for failing idle timeouts by avoiding double lock. Always create a failure if failing the callback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9169 Only fail request callback if a failure has not been otherwise notified. Slight optimisation for failing idle timeouts by avoiding double lock.