Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename JAVAX_API to JAKARTA_API in ee9 and ee10 Source #10165

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

lachlan-roberts
Copy link
Contributor

No description provided.

@lachlan-roberts lachlan-roberts requested a review from olamy July 28, 2023 05:14
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some javadoc you missed.

Also, what about the JAVAX references in jetty-core/jetty-websocket/jetty-websocket-core-common/src/main/java/org/eclipse/jetty/websocket/core/util/ReflectUtils.java ?

@lachlan-roberts
Copy link
Contributor Author

@joakime the ReflectUtils is used for both Javax and Jakarta websocket implementations. So I think it needs both.

@lachlan-roberts lachlan-roberts requested a review from joakime July 31, 2023 02:19
@lachlan-roberts lachlan-roberts merged commit 55e1074 into jetty-12.0.x Aug 1, 2023
@lachlan-roberts lachlan-roberts deleted the jetty-12.0.x-javaxSourceRename branch August 1, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants