Various Cleanup in ServletChannel #10064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lachlan-roberts can you collaborate with me on this one. |
gregw
commented
Jul 6, 2023
jetty-ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/ServletChannel.java
Outdated
Show resolved
Hide resolved
gregw
commented
Jul 7, 2023
jetty-ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/ServletChannel.java
Outdated
Show resolved
Hide resolved
gregw
force-pushed
the
experiment/jetty-12-ServletChannel-cleanup
branch
from
ee383a2
to
3d24929
Compare
|
This got too out of date. starting again.... |
|
attempt two |
We will always handle because we would not get here if there was not a matching servlet and a noop matching servlet is just a 200 response.
Removed unused upgrade method
Improved javadoc. Cleanup recycle.
…tty-12-ServletChannel-cleanup
Ensure recycle
gregw
commented
Aug 2, 2023
Comment on lines
122
to
124
| // TODO This is needed as requests that are handled before the ServletHandler are not recycled. | ||
| if (_servletContextRequest != null) | ||
| recycle(); |
There was a problem hiding this comment.
We really need a cheap and easy mechanism to trigger on request completion... i.e both callback complete and handle method exited.
Fix recycle order
|
@lachlan-roberts nudge |
lachlan-roberts
previously approved these changes
Aug 11, 2023
jetty-ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/ServletChannel.java
Show resolved
Hide resolved
janbartel
previously approved these changes
Aug 11, 2023
jetty-ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/ServletChannel.java
Show resolved
Hide resolved
jetty-ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/ServletChannel.java
Outdated
Show resolved
Hide resolved
…tty-12-ServletChannel-cleanup
removed reopen
…tty-12-ServletChannel-cleanup
Signed-off-by: gregw <[email protected]>
need reopen for persistent connections
janbartel
approved these changes
Aug 15, 2023
joakime
added
the
Specification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various Cleanup in ServletChannel