Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Request.getBeginNanoTime() accuracy #9900

Closed
lorban opened this issue Jun 12, 2023 · 1 comment · Fixed by #10909 or #10911
Closed

Improve Request.getBeginNanoTime() accuracy #9900

lorban opened this issue Jun 12, 2023 · 1 comment · Fixed by #10909 or #10911
Assignees
@lorban
Labels
Enhancement Performance

Comments

@lorban
Copy link
Contributor

lorban commented Jun 12, 2023 •
edited
Loading

Jetty version(s)
12

Enhancement Description
It currently is very inaccurate for H2, H3, FCGI, and when upgrades happen.

See #8885 for when Request.getBeginNanoTime() was introduced.

This and Request.getBeginNanoTime() should be backported to 10/11 to ease comparing performance across Jetty versions accurately.
This was referenced Jun 12, 2023
Merged
Closed
@lorban lorban moved this to 🏗 In progress in Jetty 12.0.2 FROZEN Aug 28, 2023
lorban added a commit that referenced this issue Aug 28, 2023
@lorban
#9900 accurate implementation of Request.getBeginNanoTime() for FCGI
5c7e19f 
Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban mentioned this issue Aug 28, 2023
Merged
lorban added a commit that referenced this issue Aug 29, 2023
@lorban
#9900 handle review comments
93c157d 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Aug 29, 2023
@lorban
#9900 accurate implementation of Request.getBeginNanoTime() for FCGI
c4f382a 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Aug 29, 2023
@lorban
#9900 handle review comments
e0eaa6e 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Aug 29, 2023
@lorban
#9900 accurate implementation of Request.getBeginNanoTime() for FCGI
4757333 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Aug 29, 2023
@lorban
#9900 handle review comments
67ecd9f 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Aug 30, 2023
@lorban
#9900 accurate implementation of Request.getBeginNanoTime() for FCGI
2c4adc9 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Aug 30, 2023
@lorban
#9900 handle review comments
d23ecc1 
Signed-off-by: Ludovic Orban <[email protected]>
@joakime joakime removed this from Jetty 12.0.3 Oct 11, 2023
lorban added a commit that referenced this issue Nov 21, 2023
@lorban
#9900: Accurate implementation of H2C Request.beginNanoTime()
88aab9b 
Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban mentioned this issue Nov 21, 2023
Merged
lorban added a commit that referenced this issue Nov 21, 2023
@lorban
#9900: only take begin nanotime once per stream
b419fa3 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Nov 21, 2023
@lorban
#9900: cleanup h2c nanotime code
1ab1120 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Nov 21, 2023
@lorban
#9900: remove unneeded changes
559c5ae 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Nov 21, 2023
@lorban
#9900: simplify and add test
ffc625c 
Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban moved this to 🏗 In progress in Jetty 12.0.4 - FROZEN Nov 21, 2023
lorban added a commit that referenced this issue Nov 22, 2023
@lorban
#9900: Accurate implementation of H3 Request.beginNanoTime()
61c5556 
Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban mentioned this issue Nov 22, 2023
Merged
@joakime joakime linked a pull request Nov 22, 2023 that will close this issue
Accurate implementation of H3 Request.beginNanoTime() #10911
Merged
lorban added a commit that referenced this issue Nov 23, 2023
@lorban
#9900: Accurate implementation of H2C Request.beginNanoTime()
15a9b0b 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Nov 23, 2023
@lorban
#9900: only take begin nanotime once per stream
d07a917 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Nov 23, 2023
@lorban
#9900: cleanup h2c nanotime code
ce5488e 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Nov 23, 2023
@lorban
#9900: remove unneeded changes
1625e6e 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Nov 23, 2023
@lorban
#9900: simplify and add test
10c3938 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Nov 23, 2023
@lorban
#9900: Accurate implementation of H3 Request.beginNanoTime()
f95e9ee 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Nov 23, 2023
@lorban
#9900: Accurate implementation of H3 Request.beginNanoTime()
bd7d858 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Nov 23, 2023
@lorban
#9900: handle review comments
51b76db 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Nov 23, 2023
@lorban
#9900: Accurate implementation of H2C Request.beginNanoTime()
03f2e76 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Nov 23, 2023
@lorban
#9900: only take begin nanotime once per stream
0ebea03 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Nov 23, 2023
@lorban
#9900: cleanup h2c nanotime code
b270724 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Nov 23, 2023
@lorban
#9900: remove unneeded changes
52e1824 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Nov 23, 2023
@lorban
#9900: simplify and add test
382638b 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Nov 23, 2023
@lorban
Accurate implementation of H3 Request.beginNanoTime() (#10911)
b9bd3f2 
#9900: Accurate implementation of H3 Request.beginNanoTime()

Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Nov 23, 2023
@lorban
#9900 backport Accurate implementation of H2 Request.beginNanoTime()
8b6c920 
Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban mentioned this issue Nov 23, 2023
Merged
lorban added a commit that referenced this issue Nov 23, 2023
@lorban
#9900 backport Accurate implementation of H3 Request.beginNanoTime()
542f08e 
Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban mentioned this issue Nov 23, 2023
Merged
lorban added a commit that referenced this issue Nov 23, 2023
@lorban
#9900 backport Accurate implementation of H3 Request.beginNanoTime()
1ed5783 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Nov 27, 2023
@lorban
#9900 backport Accurate implementation of H2 Request.beginNanoTime()
50f3fb4 
Signed-off-by: Ludovic Orban <[email protected]>
sbordet pushed a commit that referenced this issue Nov 27, 2023
@lorban @sbordet
#9900 backport Accurate implementation of H2 Request.beginNanoTime()
65c8b58 
Signed-off-by: Ludovic Orban <[email protected]>
sbordet pushed a commit that referenced this issue Nov 27, 2023
@lorban @sbordet
#9900 backport Accurate implementation of H3 Request.beginNanoTime()
b77a805 
Signed-off-by: Ludovic Orban <[email protected]>
@sbordet
Copy link
Contributor

sbordet commented Nov 28, 2023

Fixed and backported to 10/11.

@sbordet sbordet closed this as completed Nov 28, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.4 - FROZEN Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorban lorban

Labels
Enhancement Performance
Projects
No open projects
Jetty 12.0.4 - FROZEN
Status: ✅ Done
Milestone
No milestone
2 participants
@sbordet @lorban