jetty-12 ee10 Cross context dispatch is not supported #9774
Assignees
Comments
janbartel
added
Bug
janbartel
added a commit
that referenced
this issue
May 16, 2023
janbartel
added a commit
that referenced
this issue
May 18, 2023
|
Fixed via #9775 |
paulrutter
added a commit
to blueconic/felix-dev
that referenced
this issue
Apr 29, 2024
…n Jetty 12. See https://github.com/jetty/jetty.project/blob/jetty-12.0.x/jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/ContextHandler.java#L510 and jetty/jetty.project#9774 * Add example based on registering the websocket to the main servlet context instead of the per-bundle one -
cziegeler
pushed a commit
to apache/felix-dev
that referenced
this issue
May 1, 2024
* Revert "Add jetty websocket support to Jetty12 (#298)" This reverts commit 6d95c93. * FELIX-6692 Add Jetty WebSocket support for jetty 12.x - Apply 11.x approach to jetty12 bundle - Add two new classifiers 'with-jetty-ee10-websockets' and 'with-jakarta-ee10-websockets' to have a fat jar containing the appropriate websocket classes * Working example base on previous code. Do note that the workaround in FelixJettyWebSocketServlet are still required; the initialization code in the Jetty12 bundle doesn't seem to work * * Enable cross context support to allow WebSockets to be registered in Jetty 12. See https://github.com/jetty/jetty.project/blob/jetty-12.0.x/jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/ContextHandler.java#L510 and jetty/jetty.project#9774 * Add example based on registering the websocket to the main servlet context instead of the per-bundle one - * Added paxweb unit tests based on the Jetty11 work from #309 * Fix version * Fix message * Test casing * Update README.md * Make client optional * Add Jetty12 bundle to pom * Store the WebSocket container reference and set it on the shared servlet context once available This removes the need to set setCrossContextDispatchSupported, as the WS container is available on the proper servlet context itself * Update example to no longer use the root context. Removed other WebSocket example, as this is no longer needed with the new approach. Updated documentation. * Add servlet based example again, as it shows another example of how to register a WebSocket endpoint that abides to the servlet context it's registered to. * Rename class * Comment * Comments * Remove classloader code as it now also works without * Rename test class to EE10 * Small changes to README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jetty-12 does not (yet) support cross-context dispatch. Thus, we need to return
nullfor calls to the methodServletContextApi.getContext(String).This is also tck related, as there are many cross-context dispatch tests which should really test if the container supports cross-context before proceeding with the test - see jakartaee/servlet#488
The text was updated successfully, but these errors were encountered: