Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetty-12 ee9 & ee10 Request.upgrade returns null #9657

Closed
janbartel opened this issue Apr 17, 2023 · 1 comment
Closed

jetty-12 ee9 & ee10 Request.upgrade returns null #9657

janbartel opened this issue Apr 17, 2023 · 1 comment
Labels
Bug For general bugs on Jetty side TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)

Comments

@janbartel
Copy link
Contributor

According to the javadoc for HttpServletRequest class, the upgrade method must throw ServletException if the handler fails to be instantiated:

     * @exception IOException if an I/O error occurred during the upgrade
     * @exception ServletException if the given <code>handlerClass</code> fails to be instantiated

We are returning null as it is not yet implemented. We should at least throw a hard ServletException.
@janbartel janbartel added Bug For general bugs on Jetty side TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc) labels Apr 17, 2023
@janbartel janbartel changed the title jetty-12 ee10 ServletApiRequest.upgrade returns null jetty-12 ee9 & ee10 Request.upgrade returns null May 11, 2023
@janbartel janbartel mentioned this issue May 11, 2023
Closed
janbartel added a commit that referenced this issue May 17, 2023
@janbartel
Issue #9657
4b4768e
@janbartel janbartel mentioned this issue May 17, 2023
Merged
gregw pushed a commit that referenced this issue Jun 6, 2023
@janbartel
Issue #9657 (#9781)
6b362c0
@janbartel
Copy link
Contributor Author

Fixed via #9781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For general bugs on Jetty side TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@janbartel