Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty 12 - Make Context dumpable #9630

Closed
sbordet opened this issue Apr 5, 2023 · 0 comments · Fixed by #9885
Closed

Jetty 12 - Make Context dumpable #9630

sbordet opened this issue Apr 5, 2023 · 0 comments · Fixed by #9885
Assignees
@gregw
Labels
Enhancement

Comments

@sbordet
Copy link
Contributor

sbordet commented Apr 5, 2023

Jetty version(s)
12

Enhancement Description
Make sure that non-persistent attributes are dump()ed.

This may require that o.e.j.server.Context interface implement Dumpable and adjust for it to be a bean of ContextHandler if not already.

This will help also #9626, so that Jakarta WS client container used in a server could be dumped when the server is dumped.
@gregw gregw self-assigned this Jun 6, 2023
gregw added a commit that referenced this issue Jun 7, 2023
@gregw
Fix #9630 dumpable context
7325c54 
Added DumpableAttributes utility class
@gregw gregw mentioned this issue Jun 7, 2023
Merged
@gregw gregw moved this to 👀 In review in Jetty 12.0.0.beta2 Jun 7, 2023
@joakime joakime linked a pull request Jun 7, 2023 that will close this issue
Jetty 12 #9630 dumpable context #9885
Merged
gregw added a commit that referenced this issue Jun 8, 2023
@gregw
Jetty 12 #9630 dumpable context (#9885)
c2dc87c 
* Fix #9630 dumpable context

Added DumpableAttributes utility class

* fixed test format

* Updates from review
@gregw gregw closed this as completed Jun 15, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Jetty 12.0.0.beta2 Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregw gregw

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jetty 12 #9630 dumpable context jetty/jetty.project
2 participants
@gregw @sbordet