Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty 12 - Review BOMs #9467

Closed
sbordet opened this issue Mar 6, 2023 · 5 comments · Fixed by #9551
Closed

Jetty 12 - Review BOMs #9467

sbordet opened this issue Mar 6, 2023 · 5 comments · Fixed by #9551
Assignees
@joakime
Labels
Bug For general bugs on Jetty side

Comments

@sbordet
Copy link
Contributor

sbordet commented Mar 6, 2023

Jetty version(s)
12+

Description
There currently are mistakes in the BOM artifact/pom.xml referencing old artifacts ID that have been moved to eeN.
Also, jetty-bom/ and jetty-core/jetty-bom have the same groupId/artifactId, why do we need both?
Etc.
@sbordet sbordet added the Bug For general bugs on Jetty side label Mar 6, 2023
@olamy
Copy link
Member

olamy commented Mar 7, 2023

jetty-bom/ looks like a left over and should be removed

@manan1979
Copy link

hi @sbordet could you assign me this issue

@sbordet
Copy link
Contributor Author

sbordet commented Mar 23, 2023

@manan1979 feel free to provide a PR, and we will review it -- no need to re-assign this issue.

joakime added a commit that referenced this issue Mar 29, 2023
@joakime
Fixes #9467 - Review BOMs
c81909e
@joakime joakime mentioned this issue Mar 29, 2023
Merged
@joakime joakime linked a pull request Mar 29, 2023 that will close this issue
Jetty 12 - Review BOMs #9551
Merged
@joakime joakime moved this to 🏗 In progress in Jetty 12.0.0.beta1 Mar 29, 2023
@joakime
Copy link
Contributor

joakime commented Mar 29, 2023

Opened PR #9551

joakime added a commit that referenced this issue Mar 29, 2023
@joakime
Jetty 12 - Review BOMs (#9551)
9b7763c 
* Fixes #9467 - Review BOMs
* Skip deploy of select test artifacts
@joakime
Copy link
Contributor

joakime commented Mar 29, 2023

Merged PR #9551

@joakime joakime closed this as completed Mar 29, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.0.beta1 Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jetty 12 - Review BOMs jetty/jetty.project
4 participants
@olamy @joakime @sbordet @manan1979