-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebSocket DeploymentException
is not thrown by client nor server
#9466
Comments
@lachlan-roberts your opinion & analysis are more than welcome. |
@lorban can this be closed? |
I was reviewing this a while ago and think I even had a branch for it with some small improvements which I seem to have lost. But the |
If @joakime is happy about how we interpreted the spec, then this can be closed. |
…Container.connectToServer Signed-off-by: Lachlan Roberts <[email protected]>
…eption Issue #9466 - review where we throw DeploymentException for WebSocketContainer.connectToServer
closing as #9678 has been merged |
Jetty version(s)
verified:
11.0.x
12.0.x.beta0
still needs confirmation:
9.4.x
10.0.x
Description
In the client code, the multiple
jakarta.websocket.WebSocketContainer.connectToServer()
methods declare throwingDeploymentException
in certain conditions, but onlyIOException
is ever thrown.In the server code,
jakarta.websocket.server.ServerContainer.upgradeHttpToWebSocket()
also declares throwingDeploymentException
in certain conditions, while onlyIOException
is ever thrown.javax.websocket
implementations should be checked too.The text was updated successfully, but these errors were encountered: