Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty-12 H3 tests passing after 30s timeout #9275

Closed
gregw opened this issue Feb 1, 2023 · 1 comment · Fixed by #9280
Closed

Jetty-12 H3 tests passing after 30s timeout #9275

gregw opened this issue Feb 1, 2023 · 1 comment · Fixed by #9280
Assignees
@lorban
Labels
Bug For general bugs on Jetty side

Comments

@gregw
Copy link
Contributor

gregw commented Feb 1, 2023

Jetty version(s)
12
Java version/vendor (use: java -version)
java 17

OS type/version

linux

Description

Many of the H3 tests in org.eclipse.jetty.test.client.transport.HttpClientStreamTest are taking over 30s to complete.

Screenshot from 2023-02-01 14-54-21
Screenshot from 2023-02-01 14-54-04
Screenshot from 2023-02-01 14-53-43

How to reproduce?

Run test from IDE
@gregw gregw added the Bug For general bugs on Jetty side label Feb 1, 2023
@gregw
Copy link
Contributor Author

gregw commented Feb 1, 2023

There are also several non suppressed stacks from that test as well

lorban added a commit that referenced this issue Feb 1, 2023
@lorban
#9275 fix forcible closure of connections upon stopping the connectio…
eb0ae07 
…n pool

Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban mentioned this issue Feb 1, 2023
Merged
@lorban lorban linked a pull request Feb 1, 2023 that will close this issue
Fix connection pool's forcible stop #9280
Merged
@lorban lorban moved this to 👀 In review in Jetty 12.0.0.beta1 Feb 1, 2023
lorban added a commit that referenced this issue Feb 1, 2023
@lorban
#9275 handle review comments
618c3e4 
Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban mentioned this issue Feb 1, 2023
Merged
lorban added a commit that referenced this issue Feb 1, 2023
@lorban
#9275 handle review comments
2482b73 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Feb 1, 2023
@lorban
#9275 fix forcible closure of connections upon stopping the connectio…
55ea60a 
…n pool

Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Feb 1, 2023
@lorban
#9275 handle review comments
fdd24dc 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Feb 1, 2023
@lorban
#9275 handle review comments
da3d8ae 
Signed-off-by: Ludovic Orban <[email protected]>
gregw pushed a commit that referenced this issue Feb 1, 2023
@lorban
Fix connection pool's forcible stop (#9280)
e68c827 
* #9275 fix forcible closure of connections upon stopping the connection pool


Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban closed this as completed Feb 2, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Jetty 12.0.0.beta1 Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorban lorban

Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix connection pool's forcible stop jetty/jetty.project
2 participants
@gregw @lorban