-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review 100 continue handling in Jetty 12 #9206
Comments
Failing tests in
Tests have been |
The problem is the It's the tests that are broken, as |
This issue has been automatically marked as stale because it has been a |
Let's fix these tests in 12.1.0 and stop kicking the can along the road. |
See #12113 ? |
Fix #9206 The HttpGenerator persistence was not correctly maintained over intermediate responses. Deprecate tester in EE11 --------- Signed-off-by: Olivier Lamy <[email protected]> Co-authored-by: Olivier Lamy <[email protected]>
Description
There are some failing tests for HTTP 100 continue handling in
org.eclipse.jetty.ee10.test.rfcs.RFC2616BaseTest
.This test currently is testing only a core handler but is in ee10 tests, so either needs to be updated to test ee10 code or moved to some core test module.
The logic for 100 continue seems to be both in
ServletChannel
, and theHttpStream
implementations (do we need both), and some left in the ee9 nestedHttpChannel
. There is also some code for this inProxyHandler
,ProxyServlet
,AsyncMiddleManServlet
which could be reviewed as well.The text was updated successfully, but these errors were encountered: