Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TCK DefaultServlet handling of dispatch include incorrect #9067

Closed
janbartel opened this issue Dec 19, 2022 · 1 comment · Fixed by #9193
Closed

TCK DefaultServlet handling of dispatch include incorrect #9067

janbartel opened this issue Dec 19, 2022 · 1 comment · Fixed by #9193
Assignees
@lachlan-roberts
Labels
Bug For general bugs on Jetty side TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)

Comments

@janbartel
Copy link
Contributor

jetty-12

The DefaultServlet.doGet method is missing code to handle an INCLUDE. For an INCLUDE, the resource to be served is not found in the request (as is the case for REQUEST and FORWARD) but rather found in the request attributes prefixed with jakarta.servlet.include.:

jakarta.servlet.include.request_uri
jakarta.servlet.include.context_path
jakarta.servlet.include.servlet_path
jakarta.servlet.include.mapping
jakarta.servlet.include.path_info
jakarta.servlet.include.query_string

Note that our DefaultServletTest.testIncludedDifferentWelcomeBase unit test has been disabled with comment "Not working as RequestDispatcher.include() isn't behaving as expected".

The relevant TCK test is:
https://github.com/jakartaee/platform-tck/blob/master/src/com/sun/ts/tests/servlet/spec/multifiltermapping/URLClient.java#L249
@janbartel janbartel added Bug For general bugs on Jetty side TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc) Jetty 12 labels Dec 19, 2022
@lorban lorban assigned lachlan-roberts and unassigned lorban Dec 20, 2022
lachlan-roberts added a commit that referenced this issue Jan 18, 2023
@lachlan-roberts
Issue #9067 - Fixes to include dispatch for pathInContext and welcome…
e527dd2 
… files.

Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue Jan 18, 2023
@lachlan-roberts
Issue #9067 - Fixes to include dispatch for pathInContext and welcome…
ba58c40 
… files.

Signed-off-by: Lachlan Roberts <[email protected]>
@lachlan-roberts lachlan-roberts mentioned this issue Jan 18, 2023
Merged
@joakime joakime linked a pull request Jan 18, 2023 that will close this issue
Issue #9067 - Fixes to include dispatch for pathInContext and welcome files. #9193
Merged
lachlan-roberts added a commit that referenced this issue Feb 6, 2023
@lachlan-roberts
Merge pull request #9193 from eclipse/jetty-12.0.x-9067-DefaultServle…
39c0c09 
…tInclude

Issue #9067 - Fixes to include dispatch for pathInContext and welcome files.
@lachlan-roberts
Copy link
Contributor

Should now be fixed with #9193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
Bug For general bugs on Jetty side TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #9067 - Fixes to include dispatch for pathInContext and welcome files. jetty/jetty.project
3 participants
@janbartel @lorban @lachlan-roberts