Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpClient GZIPContentDecoder should remove Content-Length and Content-Encoding: gzip #8926

Closed
joakime opened this issue Nov 22, 2022 · 0 comments · Fixed by #10326
Closed

HttpClient GZIPContentDecoder should remove Content-Length and Content-Encoding: gzip #8926

joakime opened this issue Nov 22, 2022 · 0 comments · Fixed by #10326
Assignees
@sbordet
Labels
Bug For general bugs on Jetty side Http Client For issues encountered in Browser and Http Client implementations

Comments

@joakime
Copy link
Contributor

joakime commented Nov 22, 2022

Jetty version(s)
Jetty 10 / 11 / 12

Description
When the Jetty HttpClient's GZIPContentDecoder modifies the response and decodes a GZIP'd response automatically, it should remove the response Content-Length, Content-Encoding, and Transfer-Encoding response headers.
@joakime joakime added Bug For general bugs on Jetty side Http Client For issues encountered in Browser and Http Client implementations labels Nov 22, 2022
@jetty jetty deleted a comment from Jakester78 Nov 26, 2022
@sbordet sbordet changed the title Jetty HttpClient GZIPContentDecoder should remove Content-Length and Content-Encoding: gzip when it's performed it's duties HttpClient GZIPContentDecoder should remove Content-Length and Content-Encoding: gzip Aug 16, 2023
sbordet added a commit that referenced this issue Aug 16, 2023
@sbordet
Fixes #8926 - HttpClient GZIPContentDecoder should remove Content-Len…
a54527e 
…gth and Content-Encoding: gzip

Now Content-Length and Content-Encoding are removed/modified by the decoder.
In this way, applications have a correct sets of headers to decide whether to decode the content themselves.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet sbordet linked a pull request Aug 16, 2023 that will close this issue
Fixes #8926 - HttpClient GZIPContentDecoder should remove Content-Len… #10326
Merged
sbordet added a commit that referenced this issue Aug 21, 2023
@sbordet
Fixes #8926 - HttpClient GZIPContentDecoder should remove Content-Len… (
e91a689 
#10326)

Now Content-Length and Content-Encoding are removed/modified by the decoder.
In this way, applications have a correct sets of headers to decide whether to decode the content themselves.

Signed-off-by: Simone Bordet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbordet sbordet

Labels
Bug For general bugs on Jetty side Http Client For issues encountered in Browser and Http Client implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #8926 - HttpClient GZIPContentDecoder should remove Content-Len… jetty/jetty.project
3 participants
@joakime @sbordet and others