Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FileID.getExtension() behaviors to match new JDK 20 Path.getExtension() behaviors #8923

Closed
joakime opened this issue Nov 21, 2022 · 2 comments · Fixed by #8924
Closed

Update FileID.getExtension() behaviors to match new JDK 20 Path.getExtension() behaviors #8923

joakime opened this issue Nov 21, 2022 · 2 comments · Fixed by #8924
Assignees
@joakime
Labels
Enhancement

Comments

@joakime
Copy link
Contributor

joakime commented Nov 21, 2022

Jetty version(s)
Jetty 12

Enhancement Description
Now that we have various FileID.getExtension(*) implementations.
We should align it's behavior with the JDK 20 Path.getExtension() API behavior.

https://bugs.openjdk.org/browse/JDK-8057113
@joakime joakime self-assigned this Nov 21, 2022
@joakime
Copy link
Contributor Author

joakime commented Nov 21, 2022

Per discussion on mailing lists, some examples of expected returns on JDK 20.

Input Result
"foo.tar.gz" "gz"
"foo.bar" "bar"
"foo." ""
"foo" null
".bar" null

joakime added a commit that referenced this issue Nov 21, 2022
@joakime
Issue #8923 - Align FileID.getExtension with JDK20 behaviors
dbb3bd8
joakime added a commit that referenced this issue Nov 21, 2022
@joakime
Issue #8923 - Align FileID.getExtension with JDK20 behaviors
2c1acc1
@joakime joakime mentioned this issue Nov 21, 2022
Merged
joakime added a commit that referenced this issue Nov 21, 2022
@joakime
Issue #8923 - Fixing checkstyle
ff77fc2
@joakime joakime linked a pull request Nov 21, 2022 that will close this issue
Jetty 12 - Align FileID.getExtension() with JDK20 behaviors #8924
Merged
joakime added a commit that referenced this issue Nov 21, 2022
@joakime
Issue #8923 - Fixing WebAppClassLoader expectations
95e149b
@joakime
Copy link
Contributor Author

joakime commented Nov 22, 2022

Merged into jetty-12.0.x

@joakime joakime closed this as completed Nov 22, 2022
@olamy olamy mentioned this issue Dec 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jetty 12 - Align FileID.getExtension() with JDK20 behaviors jetty/jetty.project
1 participant
@joakime