Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QPACK decoder should fail connection if the encoder blocks more than SETTINGS_QPACK_BLOCKED_STREAMS #7635

Closed
lachlan-roberts opened this issue Feb 22, 2022 · 0 comments · Fixed by #7660
Closed

QPACK decoder should fail connection if the encoder blocks more than SETTINGS_QPACK_BLOCKED_STREAMS #7635

lachlan-roberts opened this issue Feb 22, 2022 · 0 comments · Fixed by #7660
Assignees
@lachlan-roberts
Labels
Bug For general bugs on Jetty side http3

Comments

@lachlan-roberts
Copy link
Contributor

Our QpackEncoder will not block more than SETTINGS_QPACK_BLOCKED_STREAMS streams.
But the QpackDecoder also needs to perform verification of this and fail the connection if this is violated.

https://datatracker.ietf.org/doc/html/draft-ietf-quic-qpack-21#section-2.1.2

If a decoder encounters more blocked streams than it promised
   to support, it MUST treat this as a connection error of type
   QPACK_DECOMPRESSION_FAILED.
@lachlan-roberts lachlan-roberts added the Bug For general bugs on Jetty side label Feb 22, 2022
@lachlan-roberts lachlan-roberts self-assigned this Feb 22, 2022
lachlan-roberts added a commit that referenced this issue Feb 28, 2022
@lachlan-roberts
PR #7635 - implement maxBlockedStreams logic in QpackDecoder
5cc5bc5 
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue Feb 28, 2022
@lachlan-roberts
Issue #7635 - implement maxBlockedStreams logic in QpackDecoder
39ff60f 
Signed-off-by: Lachlan Roberts <[email protected]>
@lachlan-roberts lachlan-roberts mentioned this issue Feb 28, 2022
Merged
lachlan-roberts added a commit that referenced this issue May 13, 2022
@lachlan-roberts
Issue #7635 - add extra testing for QPACK blocked streams
0b00c06 
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue May 16, 2022
@lachlan-roberts
Merge pull request #7660 from eclipse/jetty-10.0.x-7635-QpackDecoderM…
7557ae3 
…axBlockedStreams

Issue #7635 - implement maxBlockedStreams logic in QpackDecoder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
Bug For general bugs on Jetty side http3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #7635 - implement maxBlockedStreams logic in QpackDecoder jetty/jetty.project
1 participant
@lachlan-roberts