Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce jetty-home contamination warning #5263

Closed
joakime opened this issue Sep 14, 2020 · 1 comment · Fixed by #5309
Closed

Introduce jetty-home contamination warning #5263

joakime opened this issue Sep 14, 2020 · 1 comment · Fixed by #5309
Assignees
@gregw
Labels
Enhancement High Priority

Comments

@joakime
Copy link
Contributor

joakime commented Sep 14, 2020 •
edited
Loading

Jetty version
10.0.x

Description
In light of the changes coming for Issue #5256
We should move the home-base-warning module (xml, and class too) into start.jar itself now.

Warn when attempting to modify the jetty-home directory.
New command line option to bypass this contamination.
@gregw gregw self-assigned this Sep 21, 2020
@gregw
Copy link
Contributor

gregw commented Sep 21, 2020

I will implement this. I think it is sufficient to do this when automatically creating a start.d directory.

@gregw gregw linked a pull request Sep 21, 2020 that will close this issue
Issue #5263 Jetty Home warning #5309
Merged
@gregw gregw mentioned this issue Sep 21, 2020
Merged
gregw added a commit that referenced this issue Sep 22, 2020
@gregw
Issue #5263 Jetty Home warning (#5309)
592dfb8 
* Issue #5264 Jetty Home warning

Warn when using jetty home as a jetty base

* Issue #5304 HTTP2 HostHeader

 + updated more options doco and handling

Signed-off-by: Greg Wilkins <[email protected]>

* Issue #5264 Jetty Home warning

updates from review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregw gregw

Labels
Enhancement High Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #5263 Jetty Home warning jetty/jetty.project
2 participants
@gregw @joakime