Add if (LOG.isDebugEnabled()) in CompressExtension.decompress #5121
Assignees
Labels
Comments
|
Yeah you're right, these debug logs should be guarded with the |
lachlan-roberts
added a commit
that referenced
this issue
Aug 6, 2020
…pressExtension Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts
added a commit
that referenced
this issue
Aug 6, 2020
Signed-off-by: Lachlan Roberts <[email protected]>
|
I'm going to reopen this issue until the PR gets merged. |
lachlan-roberts
added a commit
that referenced
this issue
Aug 6, 2020
…in WebSocket Signed-off-by: Lachlan Roberts <[email protected]>
gregw
pushed a commit
that referenced
this issue
Aug 11, 2020
…in WebSocket (#5123) * Issue #5121 - always use isDebugEnabled() check before logging in CompressExtension Signed-off-by: Lachlan Roberts <[email protected]> * Issue #5121 - always use isDebugEnabled() check before debug logging Signed-off-by: Lachlan Roberts <[email protected]> * Issue #5121 - always use isDebugEnabled() check before debug logging in WebSocket Signed-off-by: Lachlan Roberts <[email protected]>
|
Merged for 9.4.32 and above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jetty version
jetty-9.4.x
Java version
java 1.8.u202
Question
jetty should add
if (LOG.isDebugEnabled())inCompressExtension.decompressmethod beforLOG.debugwe profile memory allocation and found that
LOG.debug("Decompress: read 0 {}", toDetail(inflater)); break;cosume some of memory as bellowThe text was updated successfully, but these errors were encountered: