Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review DeploymentManager locking #5087

Closed
sbordet opened this issue Jul 28, 2020 · 0 comments · Fixed by #5139
Closed

Review DeploymentManager locking #5087

sbordet opened this issue Jul 28, 2020 · 0 comments · Fixed by #5139
Assignees
@janbartel

Comments

@sbordet
Copy link
Contributor

sbordet commented Jul 28, 2020

Spawned by #5083.

Jetty version
9.4.x

Description
Method DeploymentManager.addOnStartupError() has the modifier synchronized to write the field, but doStart() is the only place where the field is read and it is running with a lock held.

Seems to me that the modifier synchronized is not necessary and should be removed.
@janbartel janbartel self-assigned this Aug 12, 2020
janbartel added a commit that referenced this issue Aug 12, 2020
@janbartel
Issue #5087 Use lock to protect Deployment Mgr startup errors
a44bf7a 
Signed-off-by: Jan Bartel <[email protected]>
janbartel added a commit that referenced this issue Aug 12, 2020
@janbartel
Issue #5087 Use lock in doStart for startup errors.
fa62700 
Signed-off-by: Jan Bartel <[email protected]>
@janbartel janbartel mentioned this issue Aug 12, 2020
Merged
@janbartel janbartel linked a pull request Aug 12, 2020 that will close this issue
Issue #5087 Use lock to protect Deployment Mgr startup errors #5139
Merged
janbartel added a commit that referenced this issue Aug 24, 2020
@janbartel
Issue #5087 Use lock to protect Deployment Mgr startup errors (#5139)
f143bab 
* Issue #5087 Use lock to protect Deployment Mgr startup errors

Signed-off-by: Jan Bartel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janbartel janbartel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #5087 Use lock to protect Deployment Mgr startup errors jetty/jetty.project
2 participants
@janbartel @sbordet