-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify ability to get Byte Counts about requests #4954
Comments
Signed-off-by: Joakim Erdfelt <[email protected]>
+ More updates from quick review of concept with simone Signed-off-by: Joakim Erdfelt <[email protected]>
- Minimal new API for exposing byte counts to HttpChannel. Signed-off-by: Joakim Erdfelt <[email protected]>
- Minimal new API for exposing byte counts to HttpChannel. Signed-off-by: Joakim Erdfelt <[email protected]>
…de-exposure Issue #4954 - Expose header size/length from HttpParser
This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I would still be interested in some API for this. |
@joakime I don't understand what is being suggested here? If applications have access to the jetty APIs, then we already provide listeners and API to get bytes written by connection and by request/response. |
This issue has been automatically marked as stale because it has been a |
This issue has been closed due to it having no activity. |
Jetty version
9.4.29
Description
There are several techniques used by web projects to collect information about byte counts.
Most are based on using the Servlet API.
The most common technique being ...
This has a few flaw.
Internally, the Jetty implementation is keeping track of these numbers already in the various HttpInput, HttpOutput, and HttpConnection classes.
Writing a HttpChannel.Listener for the ServerConnector is one way to utilize these numbers at the appropriate times.
However, some of the numbers have no accessors in the Jetty API.
And the nuances of the HttpChannel.Listener events and Request / Response lifecycle (recycling for example) can complicate writing such a layer against Jetty.
I propose we add a simple API to allow developers to hook into the "Request Complete" event to get the list of byte counts for every request (even those that don't go to a context).
This simple API can also be used as a demonstration on using the HttpChannel.Listener properly.
The text was updated successfully, but these errors were encountered: