Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Servlet spec 6.1 issue 300 #11815

Closed
janbartel opened this issue May 20, 2024 · 1 comment · Fixed by #12325 or #12400
Closed

Servlet spec 6.1 issue 300 #11815

janbartel opened this issue May 20, 2024 · 1 comment · Fixed by #12325 or #12400
Assignees
@gregw
Labels
Specification For all industry Specifications (IETF / Servlet / etc)

Comments

@janbartel
Copy link
Contributor

Issue 300 [https://github.com/jakartaee/servlet/issues/300]
Correct the wording in section 12.2 since the context path is not always the empty string when a servlet is mapped using context root mapping. Also clarify that context root mapping occurs for URIs with or without the trailing /

See: jakartaee/servlet#497
@janbartel janbartel added the Specification For all industry Specifications (IETF / Servlet / etc) label May 20, 2024
gregw added a commit that referenced this issue May 22, 2024
@gregw
Fix #11815 HttpServletMapping
ee3df23 
Implemented a test that uses the examples from the javadoc
Fixed the matchValue for PREFIX matches
@janbartel janbartel mentioned this issue May 23, 2024
Closed
@gregw
Copy link
Contributor

gregw commented May 23, 2024

We never implemented like that.

@gregw gregw closed this as completed May 23, 2024
gregw added a commit that referenced this issue May 25, 2024
@gregw
Fix #11815 HttpServletMapping (#11829)
a84f99b 
Implemented a test that uses the examples from the javadoc
Fixed the matchValue for PREFIX matches
@joakime joakime moved this to ✅ Done in Jetty 12.1.0 Jun 3, 2024
@olamy olamy mentioned this issue Sep 29, 2024
Merged
@olamy olamy mentioned this issue Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregw gregw

Labels
Specification For all industry Specifications (IETF / Servlet / etc)
Projects
Jetty 12.1.0
Status: ✅ Done
Milestone
No milestone
2 participants
@gregw @janbartel