Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpURI.toURI() sets userInfo to null #11465

Closed
cowwoc opened this issue Feb 29, 2024 · 1 comment · Fixed by #11468
Closed

HttpURI.toURI() sets userInfo to null #11465

cowwoc opened this issue Feb 29, 2024 · 1 comment · Fixed by #11468
Assignees
@gregw
Labels
Bug For general bugs on Jetty side

Comments

@cowwoc
Copy link
Contributor

cowwoc commented Feb 29, 2024

Jetty version(s)
12.0.6

Jetty Environment
core

Description
Similar to #7750 I am wondering why toURI() forces userInfo to null when other methods use it as-is.

I am expecting toURI() to return all the available information.
@cowwoc cowwoc added the Bug For general bugs on Jetty side label Feb 29, 2024
gregw added a commit that referenced this issue Feb 29, 2024
@gregw
HttpURI toURI passes all info
fe7e421 
Fix #11465 and #7750
HttpURI.toURI user and fragment are retained.
Use to URI(String) constructor, as all URI constructors will parse the URI anyway.
@gregw gregw self-assigned this Feb 29, 2024
@gregw gregw mentioned this issue Feb 29, 2024
Merged
@gregw
Copy link
Contributor

gregw commented Feb 29, 2024

Yeah, I see no reason not to pass those over now. If fact, considering that all URI constructors end up creating and then parsing the string version of the URI, we might as well just pass in the string version anyway. See PR #11468

gregw added a commit that referenced this issue Feb 29, 2024
@gregw
HttpURI toURI passes all info
3e2ec04 
Fix #11465 and #7750
HttpURI.toURI user and fragment are retained.
Use to URI(String) constructor, as all URI constructors will parse the URI anyway.
@sbordet sbordet moved this to 👀 In review in Jetty 12.0.7 - FROZEN Feb 29, 2024
@sbordet sbordet moved this from 👀 In review to 🏗 In progress in Jetty 12.0.7 - FROZEN Feb 29, 2024
gregw added a commit that referenced this issue Feb 29, 2024
@gregw
HttpURI toURI passes all info (#11468)
56e05a9 
* HttpURI toURI passes all info

Fix #11465 and #7750
HttpURI.toURI user and fragment are retained.
Use to URI(String) constructor, as all URI constructors will parse the URI anyway.

* HttpURI toURI passes all info

Fix #11465 and #7750
HttpURI.toURI user and fragment are retained.
Use to URI(String) constructor, as all URI constructors will parse the URI anyway.
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.7 - FROZEN Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregw gregw

Labels
Bug For general bugs on Jetty side
Projects
No open projects
Jetty 12.0.7 - FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

HttpURI toURI passes all info jetty/jetty.project
2 participants
@gregw @cowwoc