Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review number of acceptor threads #11432

Closed
sbordet opened this issue Feb 21, 2024 · 6 comments · Fixed by #11436
Closed

Review number of acceptor threads #11432

sbordet opened this issue Feb 21, 2024 · 6 comments · Fixed by #11436
Assignees
Labels
Bug For general bugs on Jetty side

Comments

@sbordet
Copy link
Contributor

sbordet commented Feb 21, 2024

Jetty version(s)
12+

Description
As reported in #11421, people can get confused by multiple acceptor threads competing for the blocking accept() call.

A suggestion is that the heuristic should default to 1, or even to 0 (i.e. the accepts will be non-blocking).

@sbordet sbordet added the Bug For general bugs on Jetty side label Feb 21, 2024
@sbordet sbordet moved this to 🏗 In progress in Jetty 12.0.7 - FROZEN Feb 21, 2024
sbordet added a commit that referenced this issue Feb 22, 2024
Defaulted to 1.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet sbordet linked a pull request Feb 22, 2024 that will close this issue
@zhipengzuo
Copy link

hello ,about selectors should be set?

@sbordet
Copy link
Contributor Author

sbordet commented Feb 22, 2024

@zhipengzuo can you clarify your question?

@zhipengzuo
Copy link

zhipengzuo commented Feb 23, 2024

@zhipengzuo can you clarify your question?
if you set acceptor = 1
should I also set selectors=1?
image

@gregw
Copy link
Contributor

gregw commented Feb 23, 2024

@zhipengzuo you typically want more than 1 selector if you want high throughput. Thus I would leave this at -1 to let the heuristic pick a value for you.
If you do want to be specific about it, then you would need to benchmark your specific algorithm to find the best value (which is unlikely to be 1).

@sbordet
Copy link
Contributor Author

sbordet commented Feb 23, 2024

@zhipengzuo
Copy link

sbordet added a commit that referenced this issue Feb 23, 2024
Defaulted to 1.

Signed-off-by: Simone Bordet <[email protected]>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.7 - FROZEN Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
No open projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants