Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocketClient should expose upgrade request/response #10749

Closed
sbordet opened this issue Oct 18, 2023 · 0 comments · Fixed by #10761
Closed

WebSocketClient should expose upgrade request/response #10749

sbordet opened this issue Oct 18, 2023 · 0 comments · Fixed by #10761
Assignees
@lachlan-roberts
Labels
Enhancement

Comments

@sbordet
Copy link
Contributor

sbordet commented Oct 18, 2023

Jetty version(s)
12+

Enhancement Description
WebSocketClient should have an easy API to access (at least) the upgrade response, so that applications can inspect response status code and headers (and possibly content).

This is currently not available because the UpgradeListener passed to WebSocketClient.connect(...) is only invoked when the upgrade is successful.
In case of failures, or non-101 responses, only the WebSocket endpoint is notified, but the response is not available.
lachlan-roberts added a commit that referenced this issue Oct 20, 2023
@lachlan-roberts
Issue #10749 - allow UpgradeListener to see Response in case of non-s…
8bd6237 
…uccessful upgrade

Signed-off-by: Lachlan Roberts <[email protected]>
@lachlan-roberts lachlan-roberts mentioned this issue Oct 20, 2023
Merged
@lachlan-roberts lachlan-roberts linked a pull request Oct 20, 2023 that will close this issue
Issue #10749 - WebSocketClient should expose upgrade request/response #10761
Merged
sbordet added a commit that referenced this issue Nov 20, 2023
@lachlan-roberts @sbordet
Issue #10749 - WebSocketClient should expose upgrade request/response (…
3d03339 
…#10761)

* Allow UpgradeListener to see Response in case of non-successful upgrade
* Using a boolean to track whether request was upgraded
* Improved exception handling in HttpUpgraderOverHTTP.
* Avoid using log warnings in CoreClientUpgradeRequest.
* Delayed setting of this.upgraded after the last throw statement.

Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Simone Bordet <[email protected]>
Co-authored-by: Simone Bordet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
Enhancement
Projects
No open projects
Jetty 12.0.4 - FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #10749 - WebSocketClient should expose upgrade request/response jetty/jetty.project
2 participants
@sbordet @lachlan-roberts