org.eclipse.jetty.server.Request uses wrong context attribute name javax.servlet instead of jakarta.servlet #10731
Assignees
Labels
Bug
For general bugs on Jetty side
Comments
olamy
added a commit
that referenced
this issue
Oct 14, 2023
…karta.servlet Signed-off-by: Olivier Lamy <[email protected]>
olamy
added a commit
that referenced
this issue
Oct 16, 2023
…karta.servlet (#10735) * Issue #10731 wrong context attribute name javax.servlet instead of jakarta.servlet Signed-off-by: Olivier Lamy <[email protected]> * Update jetty-server/src/main/java/org/eclipse/jetty/server/MultiPartFormInputStream.java Co-authored-by: Simone Bordet <[email protected]> * Update jetty-server/src/main/java/org/eclipse/jetty/server/Request.java Co-authored-by: Simone Bordet <[email protected]> * fix javadoc Signed-off-by: Olivier Lamy <[email protected]> * more usage of constant Signed-off-by: Olivier Lamy <[email protected]> --------- Signed-off-by: Olivier Lamy <[email protected]> Co-authored-by: Simone Bordet <[email protected]>
|
done |
olamy
added a commit
that referenced
this issue
Oct 17, 2023
…karta.servlet (#10735) * Issue #10731 wrong context attribute name javax.servlet instead of jakarta.servlet Signed-off-by: Olivier Lamy <[email protected]> * Update jetty-server/src/main/java/org/eclipse/jetty/server/MultiPartFormInputStream.java Co-authored-by: Simone Bordet <[email protected]> * Update jetty-server/src/main/java/org/eclipse/jetty/server/Request.java Co-authored-by: Simone Bordet <[email protected]> * fix javadoc Signed-off-by: Olivier Lamy <[email protected]> * more usage of constant Signed-off-by: Olivier Lamy <[email protected]> --------- Signed-off-by: Olivier Lamy <[email protected]> Co-authored-by: Simone Bordet <[email protected]>
olamy
added a commit
that referenced
this issue
Oct 17, 2023
…t instead of jakarta.servlet (#10735) and Address build/test failure against bad entities. (#10742) (#10745) * Issue #10731 wrong context attribute name javax.servlet instead of jakarta.servlet (#10735) * Issue #10731 wrong context attribute name javax.servlet instead of jakarta.servlet Signed-off-by: Olivier Lamy <[email protected]> * Update jetty-server/src/main/java/org/eclipse/jetty/server/MultiPartFormInputStream.java Co-authored-by: Simone Bordet <[email protected]> * Update jetty-server/src/main/java/org/eclipse/jetty/server/Request.java Co-authored-by: Simone Bordet <[email protected]> * fix javadoc Signed-off-by: Olivier Lamy <[email protected]> * more usage of constant Signed-off-by: Olivier Lamy <[email protected]> --------- Signed-off-by: Olivier Lamy <[email protected]> Co-authored-by: Simone Bordet <[email protected]> * Address build/test failure against bad entities. (#10742) Bad entities in test case can lead to: * external URL references * required HTTP GET requests * not testing redirectEntity / resolveEntity (the whole point of the test) Signed-off-by: Joakim Erdfelt <[email protected]> * use constant Signed-off-by: Olivier Lamy <[email protected]> --------- Signed-off-by: Olivier Lamy <[email protected]> Signed-off-by: Joakim Erdfelt <[email protected]> Co-authored-by: Simone Bordet <[email protected]> Co-authored-by: Joakim Erdfelt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jetty version(s)
11.0.17
Jetty Environment
Java version/vendor
(use: java -version)openjdk 17.0.4.1 2022-08-12
OpenJDK Runtime Environment Temurin-17.0.4.1+1 (build 17.0.4.1+1)
OpenJDK 64-Bit Server VM Temurin-17.0.4.1+1 (build 17.0.4.1+1, mixed mode)
OS type/version
MacOS Ventur a13.4.1 (c) (22F770820d)
Description
org.eclipse.jetty.server.Request uses wrong context attribute name in method:
private MultiParts newMultiParts(MultipartConfigElement config, int maxParts) throws IOException
Uses: "javax.servlet.context.tempdir"
Should be: "jakarta.servlet.context.tempdir"
Should use constant: jakarta.servlet.ServletContext.TEMPDIR
How to reproduce?
The text was updated successfully, but these errors were encountered: