Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EE10 ServletRequest.getProtocolRequestId() impl not spec compliant when protocol is H1 #10656

Closed
lorban opened this issue Oct 3, 2023 · 0 comments · Fixed by #10715
Closed

EE10 ServletRequest.getProtocolRequestId() impl not spec compliant when protocol is H1 #10656

lorban opened this issue Oct 3, 2023 · 0 comments · Fixed by #10715
Assignees
@gregw
Labels
Bug For general bugs on Jetty side Specification For all industry Specifications (IETF / Servlet / etc)

Comments

@lorban
Copy link
Contributor

lorban commented Oct 3, 2023

Jetty version(s)
12.0.x

Jetty Environment
EE10

Description
The jakarta.servlet.ServletRequest.getProtocolRequestId() javadoc states that when the protocol is HTTP 1.x, the empty string should be returned.

The implementation in ServletApiRequest.getProtocolRequestId() delegates the call to ChannelRequest.getId(), which got the ID from HttpStreamOverHTTP1.getId(), the latter always having some non-empty string.
@lorban lorban added the Bug For general bugs on Jetty side label Oct 3, 2023
@joakime joakime added the Specification For all industry Specifications (IETF / Servlet / etc) label Oct 11, 2023
gregw added a commit that referenced this issue Oct 12, 2023
@gregw
Fix #10656 getProtoecolRequestId
f0078d2 
Return null for HTTP/1.0 and previous
@lorban lorban linked a pull request Oct 12, 2023 that will close this issue
Fix #10656 return value for HttpServletRequest.getProtocolRequestId() in ee10 #10715
Merged
@joakime joakime mentioned this issue Oct 13, 2023
Merged
@joakime joakime moved this to 🏗 In progress in Jetty 12.0.3 - FROZEN Oct 13, 2023
gregw added a commit that referenced this issue Oct 16, 2023
@gregw
Fix #10656 return value for HttpServletRequest.getProtocolRequestId()…
897478a 
… in ee10 (#10715)

Return empty string for HTTP/1.x and previous
@gregw gregw closed this as completed Oct 17, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.3 - FROZEN Oct 17, 2023
@gregw gregw moved this to ✅ Done in Jetty 12.0.3 Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregw gregw

Labels
Bug For general bugs on Jetty side Specification For all industry Specifications (IETF / Servlet / etc)
Projects
No open projects
Jetty 12.0.3 - FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #10656 return value for HttpServletRequest.getProtocolRequestId() in ee10 jetty/jetty.project
3 participants
@gregw @joakime @lorban