-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review read failures impacting writes #10277
Comments
I think this should also help with #10234, because idle timeouts should be treated as read failures and always as hard failures for pending writes. |
While investigating a server buffer leak in While not exactly the same issue, this should be taken into account too. |
Separated read failures from write failures. In this way it is possible to read even if the write side is failed and write even if the read side is failed. Signed-off-by: Simone Bordet <[email protected]>
* Separated read failures from write failures. * In this way it is possible to read even if the write side is failed and write even if the read side is failed. Signed-off-by: Simone Bordet <[email protected]>
FIxed by #10948. |
Jetty version(s)
12
Description
Read failures should not impact writes (too much), as a write might still be possible even if the read failed.
Typical examples are early EOF in reads -- they should not impact writes.
The idea is that if a read failure is catastrophic, we would attempt the write anyway and will get the failure through the write, rather than assuming that the writes will fail.
Child issues / prs
HttpClientStreamTest.testUploadWithConcurrentServerCloseClosesStream()
#10431HttpClientIdleTimeoutTest
#10432The text was updated successfully, but these errors were encountered: