Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review ProxyConnectionFactory buffer management #10217

Closed
sbordet opened this issue Aug 3, 2023 · 1 comment · Fixed by #10225
Closed

Review ProxyConnectionFactory buffer management #10217

sbordet opened this issue Aug 3, 2023 · 1 comment · Fixed by #10225
Assignees
@sbordet
Labels
Bug For general bugs on Jetty side

Comments

@sbordet
Copy link
Contributor

sbordet commented Aug 3, 2023

Jetty version(s)
12

Description
ProxyConnectionFactory and its associated Connection implementations use RetainableByteBuffer in a non-idiomatic way, possibly leading to buffer leaks.

The code must be reviewed to ensure buffers are properly used.
@sbordet sbordet added the Bug For general bugs on Jetty side label Aug 3, 2023
@sbordet sbordet self-assigned this Aug 3, 2023
sbordet added a commit that referenced this issue Aug 4, 2023
@sbordet
Fixes #10217 - Review ProxyConnectionFactory buffer management.
fdb3eda 
Fixed buffer leak in ProxyConnection classes.
Introduced ArrayByteBufferPool.LeakTracking to test buffer leaks.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet sbordet linked a pull request Aug 4, 2023 that will close this issue
Fixes #10217 - Review ProxyConnectionFactory buffer management. #10225
Merged
@sbordet sbordet moved this to 🏗 In progress in Jetty 12.0.1 - FROZEN Aug 4, 2023
sbordet added a commit that referenced this issue Aug 16, 2023
@sbordet
Fixes #10217 - Review ProxyConnectionFactory buffer management. (#10225)
17c3649 
Fixed buffer leak in ProxyConnection classes.
Introduced ArrayByteBufferPool.Tracking to test buffer leaks.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Copy link
Contributor Author

sbordet commented Aug 23, 2023

Fixed by #10225.

@sbordet sbordet closed this as completed Aug 23, 2023
@sbordet sbordet moved this from 🏗 In progress to ✅ Done in Jetty 12.0.1 - FROZEN Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbordet sbordet

Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #10217 - Review ProxyConnectionFactory buffer management. jetty/jetty.project
1 participant
@sbordet