Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify PROXY_AUTHENTICATION is sent to forward proxies #10160

Closed
sbordet opened this issue Jul 26, 2023 · 0 comments · Fixed by #10162
Closed

Verify PROXY_AUTHENTICATION is sent to forward proxies #10160

sbordet opened this issue Jul 26, 2023 · 0 comments · Fixed by #10162
Labels
Bug For general bugs on Jetty side

Comments

@sbordet
Copy link
Contributor

sbordet commented Jul 26, 2023

Jetty version(s)
10+

Description
Pre-empted Authentication.Result should be applied to requests that are sent to forward proxies.
@sbordet sbordet added the Bug For general bugs on Jetty side label Jul 26, 2023
@sbordet sbordet moved this to 🏗 In progress in Jetty 12.0.0.beta4 Jul 26, 2023
@sbordet sbordet moved this to 🏗 In progress in Jetty 10.0.16 / 11.0.16 - FROZEN Jul 26, 2023
sbordet added a commit that referenced this issue Jul 27, 2023
@sbordet
Fixes #10160 - Verify PROXY_AUTHENTICATION is sent to forward proxies
56d658c 
Now TunnelRequest.getURI() does not return null, so normalizeRequest() can properly apply the authentication headers.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet sbordet linked a pull request Jul 27, 2023 that will close this issue
Fixes #10160 - Verify PROXY_AUTHENTICATION is sent to forward proxies #10162
Merged
@sbordet sbordet moved this to 🏗 In progress in Jetty 12.0.0 Jul 27, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 10.0.16 / 11.0.16 - FROZEN Jul 31, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.0 Jul 31, 2023
sbordet added a commit that referenced this issue Jul 31, 2023
@sbordet
Fixes #10160 - Verify PROXY_AUTHENTICATION is sent to forward proxies (…
b2477d1 
…#10162)

Now TunnelRequest.getURI() does not return null, so normalizeRequest() can properly apply the authentication headers.

Moved copy of a request to HttpRequest, so also the sub-type can be copied.
Fixed restore of destination in HttpProxy.HttpProxyClientConnectionFactory.newProxyConnection(): now doing it in the promise rather than in finally block.
Using the proxy destination (not the server's) to send subsequent CONNECT requests in case the first is not replied with 200.

Signed-off-by: Simone Bordet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #10160 - Verify PROXY_AUTHENTICATION is sent to forward proxies jetty/jetty.project
1 participant
@sbordet