fix npe when onCompleteFailure happens after reset (#12199)

Fix npe when onCompleteFailure happens after reset Signed-off-by: Ludovic Orban <[email protected]>
jetty · Aug 28, 2024 · ed1cadc · ed1cadc
1 parent aa07995
commit ed1cadc
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/jetty-core/jetty-client/src/main/java/org/eclipse/jetty/client/transport/HttpSender.java b/jetty-core/jetty-client/src/main/java/org/eclipse/jetty/client/transport/HttpSender.java
@@ -386,8 +386,11 @@ private void externalAbort(Throwable failure, Promise<Boolean> promise)
         }
     }
 
-    private void internalAbort(HttpExchange exchange, Throwable failure)
+    private void internalAbort(Throwable failure)
     {
+        HttpExchange exchange = getHttpExchange();
+        if (exchange == null)
+            return;
         anyToFailure(failure);
         abortRequest(exchange);
     }
@@ -626,7 +629,7 @@ protected void onCompleteFailure(Throwable x)
             }
 
             failRequest(x);
-            internalAbort(exchange, x);
+            internalAbort(x);
 
             Promise<Boolean> promise = abort;
             if (promise != null)