Skip to content

Commit

Permalink
#11932 improve javadoc
Browse files Browse the repository at this point in the history
Signed-off-by: Ludovic Orban <[email protected]>
  • Loading branch information
lorban committed Jun 27, 2024
1 parent d3c93bd commit cea6b4a
Showing 1 changed file with 12 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,12 @@ protected IteratingCallback(boolean needReset)
protected abstract Action process() throws Throwable;

/**
* Invoked when one task has completed successfully.
* Invoked when one task has completed successfully, either by the
* caller thread or by the processing thread. This invocation is
* always serialized w.r.t the execution of {@link #process()}.
* <p>
* This method is not invoked when a call to {@link #abort(Throwable)}
* is made before the {@link #succeeded()} callback happens.
*/
protected void onSuccess()
{
Expand Down Expand Up @@ -352,8 +357,11 @@ else if (notifyCompleteFailure != null)
/**
* Method to invoke when the asynchronous sub-task succeeds.
* <p>
* Subclasses that override this method must always remember
* to call {@code super.succeeded()}.
* This method should be considered final for all practical purposes.
* <p>
* Eventually, {@link #onSuccess()} is
* called, either by the caller thread or by the processing
* thread.
*/
@Override
public final void succeeded()
Expand Down Expand Up @@ -399,8 +407,7 @@ public final void succeeded()
* or to fail the overall asynchronous task and therefore
* terminate the iteration.
* <p>
* Subclasses that override this method must always remember
* to call {@code super.failed(Throwable)}.
* This method should be considered final for all practical purposes.
* <p>
* Eventually, {@link #onCompleteFailure(Throwable)} is
* called, either by the caller thread or by the processing
Expand Down

0 comments on commit cea6b4a

Please sign in to comment.