Restore DefaultServlet.doPost to the previous major releases' behavior (

#11300) #11299 restore DefaultServlet.doPost to the previous major releases' behavior Signed-off-by: Ludovic Orban <[email protected]>
jetty · Jan 24, 2024 · 7fbd51a · 7fbd51a
1 parent ce928e5
commit 7fbd51a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/jetty-ee9/jetty-ee9-servlet/src/main/java/org/eclipse/jetty/ee9/servlet/DefaultServlet.java b/jetty-ee9/jetty-ee9-servlet/src/main/java/org/eclipse/jetty/ee9/servlet/DefaultServlet.java
@@ -514,7 +514,7 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response)
     protected void doPost(HttpServletRequest request, HttpServletResponse response)
         throws ServletException, IOException
     {
-        response.sendError(HttpServletResponse.SC_METHOD_NOT_ALLOWED);
+        doGet(request, response);
     }
 
     @Override
@@ -535,7 +535,7 @@ protected void doTrace(HttpServletRequest request, HttpServletResponse response)
     protected void doOptions(HttpServletRequest request, HttpServletResponse response)
         throws ServletException, IOException
     {
-        response.setHeader("Allow", "GET, HEAD, OPTIONS");
+        response.setHeader("Allow", "GET,HEAD,POST,OPTIONS");
     }
 
     @Override

diff --git a/...ee9/jetty-ee9-servlet/src/test/java/org/eclipse/jetty/ee9/servlet/DefaultServletTest.java b/...ee9/jetty-ee9-servlet/src/test/java/org/eclipse/jetty/ee9/servlet/DefaultServletTest.java
@@ -2229,7 +2229,7 @@ public void testPost() throws Exception
             abcde
             """);
         response = HttpTester.parseResponse(rawResponse);
-        assertThat(response.toString(), response.getStatus(), is(HttpStatus.METHOD_NOT_ALLOWED_405));
+        assertThat(response.toString(), response.getStatus(), is(HttpStatus.NOT_FOUND_404));
 
         Files.writeString(file, "How now brown cow", UTF_8);
 
@@ -2242,7 +2242,8 @@ public void testPost() throws Exception
             abcde
             """);
         response = HttpTester.parseResponse(rawResponse);
-        assertThat(response.toString(), response.getStatus(), is(HttpStatus.METHOD_NOT_ALLOWED_405));
+        assertThat(response.toString(), response.getStatus(), is(HttpStatus.OK_200));
+        assertThat(response.getContent(), is("How now brown cow"));
     }
 
     @Test
@@ -2279,7 +2280,7 @@ public void testOptions() throws Exception
             """);
         response = HttpTester.parseResponse(rawResponse);
         assertThat(response.toString(), response.getStatus(), is(HttpStatus.OK_200));
-        assertThat(response.get(HttpHeader.ALLOW), is("GET, HEAD, OPTIONS"));
+        assertThat(response.get(HttpHeader.ALLOW), is("GET,HEAD,POST,OPTIONS"));
     }
 
     @Test